133 sats \ 17 replies \ @WeAreAllSatoshi 12 Oct 2023 \ parent \ on: Stacker Saloon
k00b and I discussed this yesterday: #281363
I'll try to look into this today if someone 😉 doesn't beat me to it.
reply
Oh thanks. Sorry I just noticed it today here. It is worse if there are many comments on the page.
reply
Don't apologize. I haven't experienced the problem for some reason so it's good to know several people are having the issue
reply
yeah afaict every change is causing a rerender ... "hook 10 & 11 changed" ... I wish the profiler could name the dang things
reply
This this? https://i.postimg.cc/7LzfwT3v/image.png
Always parse hook names from sourcereply
Sweet!
reply
I'm not sure I've pinpointed the exact issue, but making more use of
useCallback and useMemo in the MarkdownInput and UserSuggest components seems to be helping locally. At least, I see fewer longer commits in the profilerreply
I suspect if might be enough to not
setUserDropdownStyle and setMentionIndices on every change. These object literals each have a new reference and trigger a rerender even if the object is functionally identical.reply
I assume you have this change worked up locally? I won't work up a PR. LMK otherwise.
reply
Yep thanks
Yes, I think so, too. Those could only be set when there is a
@ mention query found, not just every change. We only need them to be accurate in that case.reply
deleted by author
reply
Try this*
reply
This commit might fix it: https://github.com/stackernews/stacker.news/commit/a7e016e9ba01a318d394f62ad2f0f65aa859e839
I don't have a device that exhibits the behavior though.
reply
I'll try to test it locally if I get a chance today
reply
This seems to have helped quite a bit locally. Hard to say 100% because with the dev build running locally, my machine is a bit slow, but I do think I see a usability improvement.
reply