pull down to refresh
k00b and I discussed this yesterday: #281363
I'll try to look into this today if someone 😉 doesn't beat me to it.
Oh thanks. Sorry I just noticed it today here. It is worse if there are many comments on the page.
Don't apologize. I haven't experienced the problem for some reason so it's good to know several people are having the issue
yeah afaict every change is causing a rerender ... "hook 10 & 11 changed" ... I wish the profiler could name the dang things
This this? https://i.postimg.cc/7LzfwT3v/image.png
Always parse hook names from source
Sweet!
I'm not sure I've pinpointed the exact issue, but making more use of useCallback and useMemo in the MarkdownInput and UserSuggest components seems to be helping locally. At least, I see fewer longer commits in the profiler
I suspect if might be enough to not setUserDropdownStyle and setMentionIndices on every change. These object literals each have a new reference and trigger a rerender even if the object is functionally identical.
I assume you have this change worked up locally? I won't work up a PR. LMK otherwise.
Yes, I think so, too. Those could only be set when there is a @ mention query found, not just every change. We only need them to be accurate in that case.
deleted by author
Try this*
This commit might fix it: https://github.com/stackernews/stacker.news/commit/a7e016e9ba01a318d394f62ad2f0f65aa859e839
I don't have a device that exhibits the behavior though.
I'll try to test it locally if I get a chance today
This seems to have helped quite a bit locally. Hard to say 100% because with the dev build running locally, my machine is a bit slow, but I do think I see a usability improvement.
I've also been experiencing this. I just figured it was my phone.
I've deployed the changes. Please let me know if they improved things!
Thank you fixing it. Typing works much better now :)
Thanks so much. Wasn’t sure if I fixed it
Typing in SN is very slow recently, or is it my phone dying😨 does it work well for you when you hold the backspace to delete for example? Or just typing, the letters appear a second later.