SN bug fix: multiple territory revenue for one founder \ stacker news ~meta

SN bug fix: multiple territory revenue for one founder

3209 sats \ 38 comments \ @k00b 1 Nov meta

As reported by @Jon_Hodl, founders of multiple territories were only receiving revenue for one of their territories each day.

The change I just pushed made these founders whole: for each day we should've paid them revenue on multiple territories, we've back paid them for ALL territories including repaying them for the one territory they were already paid for.

A description of the cause of the bug can be found in the footnote of this comment, which might be informative for anyone else that's in an abusive relationship with postgres.

This bug has also been fixed for any future territory revenue payments. Additionally, we weren't adding territory revenue to sats stacked as seen in profiles and that's been fixed retroactively and into the future.

The following past or current owners of multiple territories suffered from this bug and should, by the time this is posted, experienced the shown increase in their wallet balances:

nym	back sats
@siggy47	541782
@benwehrman	333332
@davidw	193687
@ek	131699
@AtlantisPleb	109638
@MaxAWebster	70078
@OneOneSeven	61384
@UCantDoThatDotNet	54372
@Jon_Hodl	37607
@nout	26488
@needcreations_	19527
@south_korea_ln	6663
@BlokchainB	6371
@lloyddunne	4829
@roytheholographicuniverse	4201
@niftynei	4065
@UCantDoThatDotRugged	3388
@kr	1851
@antic	1079
@Ed_Relight	87

view all related items

210 sats \ 11 replies \ @siggy47 1 Nov

Damn. With all those sats I need a new territory.

239 sats \ 1 reply \ @ek 1 Nov

Basically investing into SN bugs at this point

11 sats \ 0 replies \ @siggy47 1 Nov

Exactly

84 sats \ 4 replies \ @Satosora 1 Nov

Haha another territory? What would it be?

103 sats \ 3 replies \ @siggy47 1 Nov

Don't know. I actually already have more than I can handle.

43 sats \ 2 replies \ @Satosora 1 Nov

Maybe you can invest in the dog.

60 sats \ 1 reply \ @realBitcoinDog 2 Nov

~Stacker_Fitness could use a sponsor!

@grayruby willing to pledge 25k. We’re going to undercut @benwehrman and his 1000 sat pay-to-post ~health territory. We’re reviving the mortal community ~fitness and bringing it back from the dead. @Coinsreporter thinks it’s a great idea!

U in? 🐕

52 sats \ 0 replies \ @Satosora 2 Nov

Why do you need to undercut him? Just ask him to lower his fee and tell him why. More posting for him will help him become profitable. No reason to undercut him. @benwehrman thoughts?

86 sats \ 0 replies \ @Bell_curve 1 Nov

Lifetime ownership!

84 sats \ 0 replies \ @k00b OP 1 Nov

lol

64 sats \ 0 replies \ @nym 1 Nov

Linux

43 sats \ 0 replies \ @User21000000 2 Nov

Much sats much wow

210 sats \ 1 reply \ @grayruby 1 Nov

Nice! Forced Hodl!

40 sats \ 0 replies \ @realBitcoinDog 2 Nov

the best hodl

122 sats \ 0 replies \ @jakoyoh629 1 Nov

Beyond not owning any territory, I appreciate your honesty. A large sum for @siggy47. Now your wife is letting you stay up later on sn

192 sats \ 2 replies \ @Jon_Hodl 1 Nov

Wow. Glad all of that got sorted.

Looks like beers are on @siggy47

42 sats \ 1 reply \ @siggy47 1 Nov

I would say so.

64 sats \ 0 replies \ @realBitcoinDog 2 Nov

@siggy47 ought to tip you @Jon_Hodl for your service!

78 sats \ 0 replies \ @BlokchainB 1 Nov

I had zero clue hahaha but thanks!!

50 sats \ 1 reply \ @kruw 2 Nov

Good job verifying instead of trusting @Jon_Hodl !

12 sats \ 0 replies \ @Jon_Hodl 2 Nov

Yeah, I'm not sure that I really did all that much except for just trying to get all my due sats but it's refreshing to see k00b find the problem and push a fix so quickly.

It's good to see you more active here on SN. The lack of threaded replies on Bitcoin Talk makes it so difficult to follow conversations sometimes.

63 sats \ 9 replies \ @Satosora 1 Nov

Wow, thats a lot

104 sats \ 6 replies \ @k00b OP 1 Nov

It's a pretty big f-up.

157 sats \ 0 replies \ @grayruby 1 Nov

I just wanted to note that my territory identifies as multiple territories. Haha

179 sats \ 2 replies \ @siggy47 1 Nov

I had a notion something was screwy and I kept meaning to do the math. Good thing @Jon_Hodl did. When audits are available this stuff won't happen, I guess.

84 sats \ 1 reply \ @k00b OP 1 Nov

It may still happen. We'll just all know when it does.

We've done several manual audits in the past when folks have reported issues and everything was right down to the millisat. This in particular was a really subtle bug that requires understanding how a single postgres update statement might not do what it appears to - we couldn't easily reason about this a priori.

64 sats \ 0 replies \ @Satosora 1 Nov

Must really understand the fee structure and coding well.

84 sats \ 0 replies \ @Jon_Hodl 1 Nov

Your response to all of it was amazing though, k00b.

Very well done.

54 sats \ 0 replies \ @Satosora 1 Nov

You made it right, thats what counts.

63 sats \ 1 reply \ @ek 1 Nov

I thought it’d be more

87 sats \ 0 replies \ @Satosora 1 Nov

You got 131k, thats not too bad.

64 sats \ 1 reply \ @ek 1 Nov

@benwehrman with almost 333333

114 sats \ 0 replies \ @k00b OP 1 Nov

333332069 millisats so it doesn't round up sadly.

43 sats \ 0 replies \ @WeAreAllSatoshi 1 Nov

for anyone else that's in an abusive relationship with postgres.

This made me chuckle

21 sats \ 1 reply \ @Carresan 2 Nov

This posts speaks very highly of you, @k00b. It does not affects me as I am not a territory owner. However, the fact you acknowledge the bug and paying back to them, it means a lot. Keep up this great job. Also, congrats to @Jon_Hodl for taking the time to find out what was wrong.

0 sats \ 0 replies \ @Jon_Hodl 2 Nov

Yeah, k00b's response gives me a lot of faith in the direction of Stacker News.

0 sats \ 1 reply \ @OT 2 Nov

Look what you did @Jon_Hodl

32 sats \ 0 replies \ @Jon_Hodl 2 Nov