That's mostly it. 100% @ekzyis
There's a little button for adding images (probably too little) and you can also add images by dragging them to the textarea.
There's a lot of great stuff I'm actively reviewing but I know how badly you've all been waiting for this so I decided to just push it.
Someone has to ask: How secure is it to directly upload from your device?
I have no idea. I am not insinuating anything.
What would be insecure about it? Us reading all your images or something?
Browsers don't allow us to do that.
Or maybe images having metadata like Exif could contribute to leaking PII about OP e.g. location, device used to take the picture, etc.
Do we strip that before persisting to S3?
ETA: I think services like imgur strip that data for you, but I am not certain. There's so many image hosting services out there, idk how common this functionality is.
Oh that'd be cool!
Thanks for the quick answer. Service around here is amazing!
https://m.stacker.news/4225
@k00b is meta data stripped on uploads?
No. I don't think it is. I forgot that's even a thing until @WeAreAllSatoshi brought it up.
Ticket: https://github.com/stackernews/stacker.news/issues/607
If I had thought of this before now I would have commented on the PR. Thank you for asking the question @siggy47!
Yeah great point, completely forgot about that being a thing, haha
Beware!
k00b is now 100% into memes
https://i.postimg.cc/c4PggNHW/k00b-sn-fbi.jpg
proof of dog
https://m.stacker.news/4213
it works! thanks @ekzyis, been waiting on this!
They are patiently waiting for their own SN accounts and the pooch sub announcement…
And proof of cat
https://m.stacker.news/4231
https://m.stacker.news/4215
https://m.stacker.news/4242
is it ()[] or is it ?? I WILL NEVER REMEMBER!
Doesn't matter now!
https://m.stacker.news/4214
Eustace Haney
https://m.stacker.news/4216
niceeeee
Very much so
Stacker News is great. But you're making it much better.
https://m.stacker.news/4372
https://m.stacker.news/4220
Simpsons nft episode from last night 😂
Other memes
Thank you @ekzyis this was so much needed 🤟
https://m.stacker.news/4358
Bitcoin Inflation
https://m.stacker.news/4262
Bitcoin Inflation logarithmic
https://m.stacker.news/4263
source
Finally I can upload images. This is cool.
https://m.stacker.news/4329
https://m.stacker.news/4224
great new feature!
https://m.stacker.news/4243
Stack all day
https://m.stacker.news/4413
Sick
https://m.stacker.news/4361
https://m.stacker.news/4291
https://m.stacker.news/4254
It works uploading from mobile too, nice!https://m.stacker.news/4240
Wow! This is big and savings us a lot of time, Thanks guys!
Finally!! Thanksss
Bad ass dude!
https://m.stacker.news/4218
https://m.stacker.news/4217
It works 👏
https://m.stacker.news/4228
You have to wait until it's finished uploading before hitting reply.
We should disable the button (it's a bug) but we don't currently.
Love it
That's what I like. Simply this is:
https://m.stacker.news/4286
https://m.stacker.news/4276
Buying the dip.
https://m.stacker.news/4644
test img of favourite card in wallet - very handy at meetups
https://m.stacker.news/4433
https://m.stacker.news/4384
Uh oh.. it's about to get rowdy up in here.
https://m.stacker.news/4354
Proof of DICK WHITMAN
This is amazing @ekzyis!!
Bravo!
it looks like it's currently an unauthenticated so you can upload images even if you're not logged in
Meme Moday's are going to be fun
Wonderful! Great job team!
yay, finally @ekzyis
https://imgprxy.stacker.news/u-M2pOoqnYZFGcUR3nMxAZ6HaiU1kDxNIKcaHDU_eQs/rs:fit:2560:1440/aHR0cHM6Ly9tLnN0YWNrZXIubmV3cy80MjEy
https://m.stacker.news/4275
https://m.stacker.news/4272
It works
Wow!
https://m.stacker.news/4269
Nice!
https://m.stacker.news/4264
Nice!
https://m.stacker.news/4257
https://m.stacker.news/4253
working well in Asia.
Awesome!
https://m.stacker.news/4252
https://m.stacker.news/4246
I am amazed that there isn't already a markdown browser plugin that works on most sites.
for some reason the image i uploaded doesnt show up, @ekzyis
@ekzyis button is not disabled while uploading by the looks of it
Awesome!!!!
deleted by author