pull down to refresh
Make a PR ^_^
Now that would be a waste of precious time!
:(
Besides this being an ad-hoc patch and not something you'd want to publish, all it's going to do is waste everyone's time because drama, and then it gets closed. If Luke wants to tell you what to do, my patch is not going to succeed in telling Luke to not tell people what to do, while also being kinda hypocritical - after all who am I to tell Luke what policy his software should have.
Let me ask you this though: if you had a node software that was written for full operator autonomy, with no nasty shit like this, full transparency in the development process and an open repo where people can freely argue... would you run that software? would you encourage others to run it? would you contribute to it?
People are switching to Knots to express their dissent about the behavior of Core Devs regarding OP_RETURN.
I think it is possible and even correct to express to Luke the perplexity on this line of code.
At the very least, ask for a precise explanation and see how he responds to the criticisms.
Constructive criticism is always useful to everyone, moreover (I think) Luke will not delete comments as was done in the PR of Core, otherwise he will fall into dissent like Dev of Core.
Feel free to take full credit for my patch and do that!
Far be it from me to deprive you of glory. I'm not going to post PR, I wouldn't be up to it, but I think constructive criticism is always helpful.
I think incentivize is wrong because the incentive should already be there in the form of bug fixes and new features. Rather, notify would be better: could just leave a warning / popup instead of literally messing around with consensus code.
It's not censorship though imho, it's
immatellyouwhattodoship.Here's your magic
letmelivemylife.patchfwiw:diff --git a/src/clientversion.cpp b/src/clientversion.cpp index 6bf7ef6406..488d6abcb6 100644 --- a/src/clientversion.cpp +++ b/src/clientversion.cpp @@ -108,8 +108,5 @@ int64_t g_software_expiry{DEFAULT_SOFTWARE_EXPIRY}; bool IsThisSoftwareExpired(int64_t nTime) { - if (g_software_expiry <= 0) { - return false; - } - return (nTime > g_software_expiry); + return false; }