That's not bad advice. An investment doesn't have to be solely financial. Having a home that belongs to you and your family is good despite the opportunity cost of other things you could have invested in.

The worst advice I have ever been given was many moons ago. I was working in the retail business after college. I was a supervisor at a retail store and was offered a promotion to management. The local union rep that represented all non management employees said to me I should reconsider "because the union couldn't protect me anymore". Anyways, I ignored him. In the next 5 or so years I tripled my salary and worked my way up to managing a 20M dollar volume store, regional training manager and regional director. I used the connections I made to start an adjacent side business. Eventually my business grew enough to sustain my income and I worked solely at that. My business allowed me to buy a home and then a second home out of the city (where I live now) and other assets like bitcoin and stocks. I sold my business and home in the city in 2022 and semi-retired. Don't get me wrong, I am not rich (maybe rich in time), we live modestly and my wife and I both still work part time but I think things worked out ok for me without the union protecting me.