There's a lot of great stuff in here, e.g. asking questions on code reviews:
you should ask the question(s) with the assumption that the person whose code you're reviewing has a good reason for having done things differently from what you expected; and
you shouldn't refrain from asking questions, regardless of how silly or basic they may seem.
There's a lot of great stuff in here, e.g. asking questions on code reviews:
As a guesser, I don't do this enough.
I for one would welcome questions on my PRs, even if it’s just to confirm understanding of decisions made.
Sometimes I also like to do a review of my own PRs to explain myself in ways that wouldn’t really make sense as comments in the code
I love those self-reviews that you do. It's like you're answering questions I haven't asked yet!
Awesome, then it’s working as intended!
This link was posted by willm 2 hours ago on HN. It received 39 points and 10 comments.