Yes, I originally used
GetModifiedFee
, which wasn't correct as the fee was modified with, IIRC, ancestors in ways that didn't work correctly with replace-by-fee-rate. So I changed it in a later commit to GetFee
.I believe that will also work incorrectly in cases where fees are manually prioritized, as, IIUC, manual priorities are done via
GetModifiedFee
. But I haven't had time (or funding) to fix those issues yet. This code is just testing the idea out right now.Good work!
reply
CFeeRate original_feerate(mi->GetModifiedFee(), mi->GetTxSize());
not want to use ModifiedFee? since it's fetching the original fee rate?