pull down to refresh
0 sats \ 8 replies \ @ek 25 Oct 2023 \ parent \ on: Bookmark settings bug meta
Was able to confirm this
Thanks for the report!
Yay! Happy to have helped!
reply
So basically the session needs updating on nym change?
reply
Yes. Or better: we should use user ids.
reply
Yea, I didn’t want to refactor it to use IDs when I originally implemented the privacy feature, just to keep the changes smaller. But using IDs would have prevented this. However, it still surfaced a bug that needs fixing
reply
No worries, fix is simple :)
reply
I still think we should update the session on nym change too, even though this change fixes the bookmark issue
reply
That would be ideal, yes
But I have the feeling it's not going to be simple. We would have to reissue a JWT which is handled by next-auth. Can we issue a new JWT without the need for reauthentication? Should we even be able to do that?
reply
Good catch!
reply