pull down to refresh

And for some reason I still get empty push notifications even though I thought I fixed that.

Maybe my serviceworker didn't update? But it should update immediately.

Or that is caused by this caching issue you were talking about

reply

Cache issue should be fixed

I’d just search for matchall somewhere

reply

Mhh, matchAll is literally only used here but I think the default is not applied because we explicitly pass null as the argument:

lib/item.js:

export const getDeleteCommand = (text = '') => {
  const matches = [...text.matchAll(deletePattern)]
  const commands = matches?.map(match => ({ number: match[1], unit: match[2] }))
  return commands.length ? commands[commands.length - 1] : undefined
}

export const hasDeleteCommand = (text) => !!getDeleteCommand(text)

api/resolvers/item.js:

if (hasDeleteCommand(old.text)) {
    // delete any deletion jobs that were created from a prior version of the item
    await clearDeletionJobs(item, models)
  }
reply
reply

Thank you 🙏

reply

No worries :)

reply

Reinstalled PWA. Let's see

reply
reply