Wasn't there another epic PR that lasted for years, something about separating the GUI from the rest of the code, that finally got merged a couple of years ago? Was ryanofsky behind that one, too?
Sounds familiar, but my github skillz are not up to the job of investigating.
Open unmerged PRs for a months / years is Bitcoin style, also in other projects. Recently one refactoring PR for JoinMarket by me got merged after around 6 months.
Crazy that this thing has been floating around for 6 years!
Yea, imagine rebasing a PR for 6+ years. There’s over 1000 items in the PR activity chain. My goodness
Wasn't there another epic PR that lasted for years, something about separating the GUI from the rest of the code, that finally got merged a couple of years ago? Was ryanofsky behind that one, too?
Sounds familiar, but my github skillz are not up to the job of investigating.
Open unmerged PRs for a months / years is Bitcoin style, also in other projects. Recently one refactoring PR for JoinMarket by me got merged after around 6 months.
Lots of ACKs. Is CPU time - outside of ibd - that contentious in core?