reply on: Code review tool recommendations \ stacker news ~tech

pull down to refresh

10 sats \ 8 replies \ @k00b OP 20 Aug 2023 \ parent \ on: Code review tool recommendations tech

Hmmm I'm not sure this is what you're suggesting, but maybe I should save the git diffs to a file locally and write all my notes there!

10 sats \ 7 replies \ @nemo 20 Aug 2023

deleted by author

31 sats \ 2 replies \ @k00b OP 20 Aug 2023

In some cases the code is fine but I suspect it could have uncaught corner cases or improved but I'm not 100% sure and I don't want to "alert" the author if I'm wrong.

100 sats \ 0 replies \ @_redacted 20 Aug 2023

Corner cases are were code reviews are really helpful! It's taken many years to separate "you should have done it how I would have done it" from "this code is ok to be merged". It's helpful to think "does this pr improve the code overall".

Bugs will happen. Keeping the critical sats-related code separate from the rest, + CODEOWNERS will keep the critical sections safer while letting the rest change more quickly.

10 sats \ 0 replies \ @nemo 20 Aug 2023

deleted by author

100 sats \ 3 replies \ @nemo 20 Aug 2023

deleted by author

10 sats \ 2 replies \ @nemo 20 Aug 2023

deleted by author

31 sats \ 1 reply \ @k00b OP 20 Aug 2023

Noooo I don't want more tools lol. I want one really good one. 😄

10 sats \ 0 replies \ @nemo 20 Aug 2023

deleted by author