My first bitcoin PR \ stacker news ~bitcoin

No, I'm not a Bitcoin Core maintainer. Anybody can ACK or NACK commits in a PR after code review / testing (and the more people do this, the better). Maintainers are the only ones who can merge them at the end. But they are not supposed to use these rights if there are a lot of NACKs or not enough ACKs for more complex code changes.

https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md

0 new comment

0 sats \ 2 replies \ @ek OP 9 Mar 2023

Yes, I know about the ACKs and NACKs. But I don't see an approve button. So I thought you have some special rights:

https://i.postimg.cc/bJyfvDMc/2023-03-09-173415-916x170-scrot.png

0 new comment

21 sats \ 1 reply \ @kristapsk 9 Mar 2023

Ahh, no, that's just what GitHub writes if you select "Approve" instead of "Comment" at "Files changed > Review changes".

https://imgur.com/gGktFJ3.png

0 new comment

0 sats \ 0 replies \ @ek OP 9 Mar 2023

Ah, I see haha

reply on another page

19 sats \ 0 replies \ @mf 9 Mar 2023

https://media2.giphy.com/media/1hAxQTH0HEWS3L0oRF/giphy.gif?cid=ecf05e470on5w17mkmyy2ujs8kwc98fxsng3cppfhthtxsdn&rid=giphy.gif&ct=g

0 new comment

9 sats \ 1 reply \ @jx 12 Mar 2023

Cool. Followed you on GH!

0 new comment

0 sats \ 0 replies \ @ek OP 12 Mar 2023

Haha thanks!

0 new comment

9 sats \ 1 reply \ @duvel 11 Mar 2023

Fantastic! How did you manage to do your first pr? What were the necessary steps you had to take?

0 new comment

0 sats \ 0 replies \ @ek OP 12 Mar 2023

As mentioned in the PR, I reviewed some code before and then found something which I thought could be improved.

Before contributing, I was intimidated since my C++ skills aren't really that great. But I thought this can change over time.

So when I decided I really want to contribute to bitcoin, I first read some articles like this one from @jonatack. I also lurked on Bitcoin PRs to see the process in action and joined the Bitcoin PR review club twice. (It's every Wednesday at 17:00 UTC on IRC but I always forget about it lol)

I also cloned the repository and checked out the code to get familiar with it. I haven't run the test suite yet, though.

But as @jonatack and others mentioned: Just start by looking over existing PRs and try to understand what they are trying to change! Reviewers are definitely needed the most.