pull down to refresh
I mention most of my nits. I think you should in this case too. The test framework option was introduced after the original PR was opened: https://github.com/bitcoin/bitcoin/commit/c985eb854cc86deb747caea5283c17cf51b6a983 , so it should have been picked up during some rebase along the line.
It is very quick to fix and there are other review comments that require action from the author anyway.
Thank you for taking the time to reply!!
I didn’t realize the framework option was introduced later. I will definitely mention this nit now.
Thank you for letting us summon you!
I mention most of my nits. I think you should in this case too. The test framework option was introduced after the original PR was opened: https://github.com/bitcoin/bitcoin/commit/c985eb854cc86deb747caea5283c17cf51b6a983 , so it should have been picked up during some rebase along the line.
It is very quick to fix and there are other review comments that require action from the author anyway.