22 sats \ 3 replies \ @k00b 10 Mar 2022 \ on: Daily discussion thread
Working on a bunch of random stuff today before beginning to work on offering sat yield.
Pushing some updates right now
3449589 (HEAD -> master) provide 'plain text' email login link for users using embedded browsers in their mobile email clients e9e48d5 better regex for url validation 8ca33b1 detect dupes between both youtube url types f241f14 improve tipping walkthrough: don't display if user doesn't have sats, more generic error message f35d714 add close button to all modals 3f59d02 more indices 7997085 add more indices to item 17ae89c
reply
Twitter embeds are working properly again, I see. Can you share what the underlying issue was?
reply
It was a race condition. I render the twitter embed in a container of fixed size so there isn't layout shift. I then use an "onload" callback to determine when the iframe loads to detect if there's overflow. If there's overflow, I display the button to expand the container. It appears that the onload callback was being triggered before the content loaded in a way that would allow me to measure its height. The fix was just to assume that the container always has overflow (which it will) and always display the button following onload.
reply