My pr has finally been merged at https://lightningaddress.com :-)
pull down to refresh
0 sats \ 2 replies \ @cointastical 9 Feb 2023
Yay!! That had been an outstanding task for nearly half a year.
If you were willing to tackle an additional task that would help SN, I had a pull request to add Stacker News to the BlueWallet Marketplace page, but I guess I had deleted the repo that I had forked which I had used for my pull request, and deleting that also closed the ticket.
This was something initially suggested nearly a year ago and it just has not been top of mind.
It still could be resubmitted though, by someone who doesn't delete their repos willy nilly 😜.
reply
20 sats \ 0 replies \ @duvel OP 19 Jun 2023
I created a pr a while ago, but it seems that their build image on Netlify is using an old version that is not supported. Which is why the build fails.
https://github.com/BlueWallet/Website/pull/280
reply
20 sats \ 0 replies \ @duvel OP 9 Feb 2023
Glad to help. I'll take a look at that.
reply
0 sats \ 2 replies \ @ama 9 Feb 2023
What does that mean?
What is your pr?
What does "merged at" means?
Is it just that a link for SN has been added at the LA collection of links or does it include something else?
reply
0 sats \ 1 reply \ @duvel OP 9 Feb 2023
This was the pr to add the website and logo of Stacker news, where you can get a Lightning address, to the Lightningaddress.com website.
https://github.com/andrerfneves/lightning-address/pull/93
reply
0 sats \ 0 replies \ @ama 9 Feb 2023
Thank you for replying. I have no clue why I asked "What is your pr". when my actual problem was that I had no clue what "pr" stand for. From your answer, now, I believe it might mean "promise". The same happened with my question about "merged at". :-)
Perhaps I should spend more time studying English and less on Nostr and SN. Haha
reply
0 sats \ 1 reply \ @k00b 8 Feb 2023
Finally! Thank you!
reply
0 sats \ 0 replies \ @duvel OP 8 Feb 2023
:-)
reply