reply on: How are you balancing newcomer training with drive-by LLM solution filtering? \ stacker news ~AI

pull down to refresh

344 sats \ 5 replies \ @SimpleStacker 26 Aug \ parent \ on: How are you balancing newcomer training with drive-by LLM solution filtering? AI

it was surprising to me to see how many people submit PRs but say they haven't tested it. I try to test everything (as much as I can), even single line code changes, and wouldn't imagine submitting something for review without having done so.

144 sats \ 0 replies \ @optimism 26 Aug

Took me years to get rid of "LGTM" culture in reviews, which ultimately heightened review quality. Now the pressure is on the submitter because no one will want a fight when their review on an untested PR breaks shit

It sucks that FOSS development brings much stress and isn't always newcomer friendly but if you have a massive installed base you have to deliver quality work and avoidable debt on your main branch is going to hurt.

100 sats \ 3 replies \ @sox 26 Aug

I'm okay with AI contributions, to me the most important part is how your human brain arrived at the solution. I default to this.

how many people submit PRs but say they haven't tested it

But the problem is when they say they tested it when they didn't, which automatically invalidates any assumptions I could make about the usage of human logic. And I also get a little frustrated maybe because it seems that they don't value what they publish, while, like you, I get anxious even on single line code changes.

100 sats \ 2 replies \ @optimism 26 Aug

I get anxious even on single line code changes.

Unit tests often help with anxiety. "this was broken", see test. "now it's no longer broken", see test. "it has no negative impact on other features", see all the other tests.

100 sats \ 1 reply \ @sox 26 Aug

I gotta step up my tests game, I only make them temporarily and arbitrarily.

This is another lesson in discipline I have to give myself ngl

0 sats \ 0 replies \ @optimism 26 Aug

If you have decent coverage, it helps with spotting regressions in the future. The worst thing that ever happened imho on some code I wrote was that I wrote tests, then the tests got commented out by someone else and I missed that in a PR review. Then of course there was a regression and there was drama.