Dialogue rules and punctuation are tricky (I don't always get it 100% right). I recommend using the Grammarly extension (free version) to help fix little errors that can distract the reader. It'll also help you learn the rules too.