Bitcoin Core hits 10,000 merged PRs - Murch \ stacker news ~bitcoin

pull down to refresh

Bitcoin Core hits 10,000 merged PRs - Murch x.com/murchandamus/status/1958194011904086165

482 sats \ 11 comments \ @Scoresby 21h bitcoin

zaps forwarded to @Murch (100%)

Alternatively:

There have been a total of 42 pull requests opened to Knots. 26 are open and 16 are closed without merge. Not one developer has a merged PR in Knots—not even Luke, who pushes code changes directly to the master branch. You can see this yourself by taking a look at the Knots repo.

#155 – Zero comments, closed by PR author #124 – Declined by maintainer #107 – Retracted by PR author #89 – Review not incorporated, closed by author #86 – Closed without comment #85 – Declined by maintainer #84 – Typo fix picked up in other commit #78 – Merged according to PR author, but via a different commit than the one in the branch #76, #55 – 2× One line to add missing dependency adopted by maintainer #54 – Doc update, unclear whether it was merged #53 – Declined #27 – Closed, issue fixed independently #23 – Declined #13 – PR declined for being obsolete #11 – Declined

view all related items

0 replies \ @Scoresby OP 5h

NOTE: I combined two separate X threads from Murch in this post but I don't think I made it clear. This created the impression that Murch was comparing the two projects based on merged PRs, which I don't believe he was doing.

Comparing the two projects based on merged PRs isn't an apples to apples comparison, though, as @optimism points out below.

Sorry to be a source of confusion.

212 sats \ 7 replies \ @optimism 21h

You can't really compare a downstream fork (and especially not a rebasing one) to its upstream though, that's not apples to apples, because the fork can (and often does, also outside of this particular instance) include all or much of the upstream work too. Besides, Core is still the reference client, so you can't really compare any other Bitcoin client to that.

What you can do is compare btcd to libbitcoin, or compare knots to Peter's libre-relay if you want apples-to-apples.

202 sats \ 4 replies \ @Murch fwd 7h

In case it's not obvious from @Scoresby's post, these two tweets were not in the same thread.

102 sats \ 2 replies \ @optimism 6h

My comment wasn't personally directed at you.

100 sats \ 1 reply \ @Scoresby OP 6h

I didn't take them as such. But I am the one who combined these posts from @murch when they were posted in separate contexts.

I didn't think it through all that much, so your comments were helpful and much appreciated. But it raises the question in my mind next: when should one delete a post (I don't want to mislead anyone who doesn't read the comments here) versus leaving it up because it might help with education if they do read the comments?

102 sats \ 0 replies \ @optimism 6h

Just pin an explainer.

121 sats \ 0 replies \ @Scoresby OP 7h

Yes, it's definitely me who, in my ignorance, was drawing the comparison here. I probably should have made that more clear.

202 sats \ 1 reply \ @alice_bob 10h

Yeah they know but in the absence of solid arguments it only remains to spread FUD to fill hollow skulls.

112 sats \ 0 replies \ @optimism 10h

Echo chambers be echochamberin'...

It's the suckiest thing, because individually, the people involved are awesome... but I guess it's only human for lotalty to the tribe to trump common sense. It's lonely being an outsider.

0 sats \ 0 replies \ @BITC0IN 20h

Congrats

0 sats \ 0 replies \ @nitter 21h bot

https://xcancel.com/murchandamus/status/1958194011904086165