pull down to refresh

SN release: live comments, wallet v2 fixes with opt-in debug logs, small fixes

3260 sats \ 53 comments \ @k00b 23 Jul meta

live comments

When you're viewing a thread and new comments show up, we now show indicators which you can click to reveal new comments. The goal is for threads to be a little more lively, higher velocity, like chat (without shifting the page around while reading). We plan on adding many more enhancements to this, but it should be useful already. (via @sox)

wallet v2 fixes

passphrase scanner bug
wallet encryption key was sometimes stored ephemerally
fixes to wallet logging

via @ek

wallet debug logs

wallets/debug - this mostly for interactive troubleshooting when folks are having issues with their wallets

via @ek

View all commits here: https://github.com/stackernews/stacker.news/commits/master/

Since starting the Open Source Contributor Award Rules (OSCARs), we've paid a total of 24.8m sats to 49 contributors for 253 contributions! View a nearly up to date list of contribution awards here: https://github.com/stackernews/stacker.news/blob/master/awards.csv

Previous release: #1041565

view all related items

222 sats \ 4 replies \ @Undisciplined 23 Jul

That’s going to make our discussion threads so much better!

52 sats \ 2 replies \ @WeAreAllSatoshi 23 Jul

Oh I didn't see you already made this comment

139 sats \ 1 reply \ @Undisciplined 23 Jul

That’s quite ironic

62 sats \ 0 replies \ @WeAreAllSatoshi 23 Jul

lol right?

52 sats \ 0 replies \ @sox 23 Jul

it did already!

190 sats \ 0 replies \ @sox 23 Jul

I did say that the air felt live! ok now let's all hope nothing breaks

244 sats \ 0 replies \ @Scoresby 23 Jul

Live comments is really cool! I've many times had the experience of getting absorbed in writing a comment only to realize the conversation moved on while I was writing. Nice to get a sense of what's happening without needing to refresh the page.

170 sats \ 7 replies \ @WeAreAllSatoshi 23 Jul

Very cool!

immediately opens dev tools to see how it works

58 sats \ 3 replies \ @k00b OP 23 Jul

we be polling

92 sats \ 2 replies \ @felipe 23 Jul

41 sats \ 1 reply \ @WeAreAllSatoshi 23 Jul

You can go a long way with polling. Sure it’s not the most optimal, but often the other methods are very complicated and hard to get perfect.

83 sats \ 0 replies \ @felipe 23 Jul

Yeah, I'm a dev, I know that for a fact because I use it all the time 😄

I rarely go for a more complex solution like sockets or something else

0 sats \ 2 replies \ @WeAreAllSatoshi 23 Jul

Did you have to make any infra adjustments for the potential large increase in requests?

50 sats \ 1 reply \ @k00b OP 23 Jul

nope. we might have to add some new indices but the load should otherwise be pretty minimal at our scale.

148 sats \ 0 replies \ @WeAreAllSatoshi 23 Jul

This is going to be great for live game discussions in ~Stacker_Sports

@grayruby @Undisciplined

171 sats \ 3 replies \ @grayruby 23 Jul

Live comments is awesome!

40 sats \ 2 replies \ @BlokchainB 23 Jul

I need to see this live comment item in action to understand it

96 sats \ 1 reply \ @k00b OP 23 Jul

reply to this comment and stay on the page. I'll reply to you and you can see it.

40 sats \ 0 replies \ @BlokchainB 24 Jul

I saw it in action it’s really cool

161 sats \ 0 replies \ @Scoresby 23 Jul

Woah:

150 sats \ 2 replies \ @ek 23 Jul

Regarding wallet debug logs:

There's no link to the page anywhere in the UI on purpose since I want to link stackers to it on demand.

But if you're interested, here's one: /wallets/debug

@OT, @StillStackinAfterAllTheseYears, have your wallets been locked again since the last time? Can you reply with a screenshot of the page? (There's no sensitive information on it.)

If you want, you can also enable diagnostics, then I can see if there's anything interesting in the debug logs the next time it happens.

36 sats \ 1 reply \ @OT 24 Jul

It hasn't happened for a while. Looks like it's working.

BUT

I might have found a new bug... When I want to paste a link into a post or comment the long press generates a Select All. After clicking Select All I'm then able to paste the link but it threw me off a few times.

0 sats \ 0 replies \ @ek 24 Jul

I might have found a new bug... When I want to paste a link into a post or comment the long press generates a Select All. After clicking Select All I'm then able to paste the link but it threw me off a few times.

Mhh, this sounds like an operating system thing

50 sats \ 0 replies \ @WeAreAllSatoshi 23 Jul

It might be nice for a top-level, or fixed-with-scrolling indicator when new comments are available, as I may not be scrolled to the item sub-tree where new comments were added

100 sats \ 3 replies \ @0xbitcoiner 23 Jul

cool. good job @sox and sn team!

178 sats \ 2 replies \ @k00b OP 23 Jul

the screenshot keeps making me think there are new comments

21 sats \ 1 reply \ @WeAreAllSatoshi 23 Jul

Just switch to light mode, then you won't mistake it for being a real comment thread

50 sats \ 0 replies \ @k00b OP 23 Jul

50 sats \ 4 replies \ @k00b OP 23 Jul

@WeAreAllSatoshi we have a fixed indicator for top level comments (I'm adding a top level for you to get a chance to see it ... maybe).

In general I think this will lead to a bunch of new enhancements around unseen comments. We already plan to change the favicon on new comments, and I want to have a fixed next button, kind of like how docusign does, for going to each new comment. I also don't want to have to click to reveal new comments (but we'll need to get clever with height calculations).

71 sats \ 2 replies \ @sox 23 Jul

✍️ fixed next button

69 sats \ 1 reply \ @k00b OP 23 Jul

yep, I was going to tag you! it'd be nice if that feature wasn't dependent on live comments and also worked for when we just revisit a thread that has new comments.

21 sats \ 0 replies \ @sox 23 Jul

that's actually even cooler! I'm sure that IntersectionObserver will make this relatively trivial.

0 sats \ 0 replies \ @WeAreAllSatoshi 23 Jul

Cool, I hadn't seen it yet, but now I did!

I'm excited to see the developments here.

100 sats \ 2 replies \ @0xbitcoiner 24 Jul

It’d be cool to have a live feature for posts on the ‘https://stacker.news/recent’ page. Is it easy to set up, @sox?

33 sats \ 1 reply \ @sox 24 Jul

I don't necessarily think that it's difficult, I need to look into it ^^

@ek is this what you meant with live posts?

69 sats \ 0 replies \ @ek 24 Jul

yes

100 sats \ 0 replies \ @plebpoet 24 Jul

it's live in here

100 sats \ 0 replies \ @k00b OP 23 Jul

going to keep this open just to feel alive

0 sats \ 2 replies \ @k00b OP 25 Jul

hey @Car

0 sats \ 1 reply \ @Car 25 Jul

hey you were on snl right now where you at

1 sat \ 0 replies \ @k00b OP 25 Jul

yeah I know

0 sats \ 0 replies \ @Car 25 Jul

still haven't seen it show me k00b

0 sats \ 3 replies \ @nelom 25 Jul

Sorry @k00b, when you add a ln recieve wallet, does it confirm with an orange colour now, instead of green?

Or is that signifying a fault?

0 sats \ 2 replies \ @k00b OP 25 Jul

I'd only worry if it were red. The orange signifies warning. Meaning there's some recent wallet history suggesting the wallet didn't work as intended.